Skip to content

Conversation

aishvarya252
Copy link

@aishvarya252 aishvarya252 commented Dec 6, 2024

Describe your change:

This pull request adds an implementation of the Polyalphabetic Cipher, a classical cryptographic technique that uses multiple substitution alphabets for encryption and decryption. The implementation includes both encryption and decryption functions, supporting cyclic use of a key to determine letter shifts. Non-alphabetic characters are preserved during processing.

Reference
For more details on the Polyalphabetic Cipher, refer to the Wikipedia page: https://en.wikipedia.org/wiki/Polyalphabetic_cipher

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.

Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This is not a Python file. Valid Python files must end with a .py file extension.
  2. This file isn't in any existing directory. If we were to merge this PR, this file should belong in the ciphers directory.
  3. What kind of polyalphabetic cipher is this? Is this a Vigenere cipher? You didn't include any explanation of the algorithm or any sources.

Comment on lines +48 to +55
plaintext = "HELLO, WORLD!"
key = "KEY"

ciphertext = encrypt(plaintext, key)
print("Encrypted Text:", ciphertext)

decrypted_text = decrypt(ciphertext, key)
print("Decrypted Text:", decrypted_text)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main function code should be in an if __name__ == "__main__": block

@tianyizheng02 tianyizheng02 added the awaiting changes A maintainer has requested changes to this PR label Dec 30, 2024
@cclauss
Copy link
Member

cclauss commented Oct 14, 2025

Closing awaiting_changes PRs to prepare for Hacktoberfest

@cclauss cclauss closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes A maintainer has requested changes to this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants