Skip to content

chore: add security ruleset to PMD #6292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jun 14, 2025

This PR adds the security rulse set to the current PMD config. There are more exiting rule sets like:

but they require suppressing MANY warnings in our case. This rule set can be added for free.

Continuation of #5155.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@b427b40). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6292   +/-   ##
=========================================
  Coverage          ?   74.09%           
  Complexity        ?     5345           
=========================================
  Files             ?      677           
  Lines             ?    18639           
  Branches          ?     3618           
=========================================
  Hits              ?    13810           
  Misses            ?     4273           
  Partials          ?      556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 marked this pull request as ready for review June 14, 2025 15:06
Copy link
Collaborator

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@DenizAltunkapan DenizAltunkapan merged commit a21abe6 into TheAlgorithms:master Jun 14, 2025
6 checks passed
@vil02 vil02 deleted the add_security_ruleset_to_pmd branch June 14, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants