DNB_hungarian_fix ver0.1 #410
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//The extra commits are for testing why 00_events_0090000.csv shows so many strange changes.
// It has been tested many times and does not affect the use.
// I really don't understand how to solve the automatic transcoding problem of GitHub web pages
Original Issues in TGC 2.5.2
If the KUK (Austro-Hungarian Empire) forms the South German Confederation, it causes the already established KUK to no longer accept the Hungarian ethnicity.
However, when such a KUK attempts to form the Danubian Federation (DNB), even if the Hungarian ethnicity fully accepts the proposal, the resulting DNB still does not accept Hungarians.
Analysis of the Original Issues
Investigation reveals that in the events folder, the Post-Formation Events group in DNBFlavor.txt does not include a follow-up event for full Hungarian agreement.
It is speculated that the TGC team discovered that applying the old template could result in a federation where Hungarians agree but the remaining Cisleithanian ethnicities do not, potentially granting the entire Cisleithania core unexpectedly.
Consequently, the TGC team removed the original event but has not yet added a revised one.
My Solution
Add a post-formation event for full Hungarian agreement with ID 98689, and manually add cores for Little Hungary based on province IDs.
Known Issues with My Solution
a: The original mod has very limited event ID availability, and event IDs in DNBFlavor.txt are strictly ordered, so the new event ID does not strictly follow the original sequence.
b: Other ethnicity events are tied to the global_flag=full_hungarian_approval, but I cannot control the timing of ID 98689 to occur last, so the flag is not recycled.
c: The event ID uses an existing obsolete case
This has been tested on my computer and runs normally. If any bugs are found, please submit them.