Added back viceroyalty tags, updated loc, updated decisions accordingly #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spanish Viceroyalties are back and working as intended. VNS, VLP, VNG, VOP, and CGC.
All SPA decisions and JANFlavor have been updated accordingly. These viceroyalties have to be on Colonial Company gov to work as intended. Otherwise, their loc won't make sense.
Speaking of, I've updated LOC slighly to accomodate for this. If VNS is colonial_company then it is named Viceroyalty of New Spain. If MEX is colonial_company, it is named New Spain. This way, it is easier to distinguish the two when looking at their cores in the province view ui.
I have done a bunch of testing and found most of this works. I managed to establish all of the Viceroyalties. The remaining bugs are: