Allow custom spinners across rich
library
#3791
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Resolves #3790
The feature
Spinner
,Console.status
,Status
andprogress.SpinnerColumn
(let me know if I missed anything)Documentation
console.rst
Is this worth adding despite Rich rejecting most new features?
Design considerations
Spinner
object themselves, rather than their assorted set of other parameters (spinner
,spinner_style
andspeed
), which would make patterns like dependency injection simplerSpinner
object (rather than constructing one based on these parameters) would make those other parameters ambiguous in the case where aSpinner
object is given.