Skip to content

Truncate long object representations in to_repr #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Truncate long object representations in to_repr #3773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rich/pretty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,8 @@ def to_repr(obj: Any) -> str:
else:
try:
obj_repr = repr(obj)
if max_string is not None and len(obj_repr) > max_string:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not keen on using max_string for things other than repr. Suggest max_repr.

Additionally, these two lines don't belong within the Exception block, since we aren't expecting this code to throw exceptions.

obj_repr = f"{obj_repr[:max_string]}..."
except Exception as error:
obj_repr = f"<repr-error {str(error)!r}>"
return obj_repr
Expand Down