Skip to content

[fix] added extras to log table #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions llmstudio/engine/providers/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class ChatRequest(BaseModel):
functions: Optional[List[Dict[str, Any]]] = None
session_id: Optional[str] = None
retries: Optional[int] = 0
extras: Optional[Dict[str, Any]] = None


class Provider:
Expand Down Expand Up @@ -159,19 +160,14 @@ async def handle_response(
else request.chat_input
),
"provider": self.config.id,
"model": (
request.model
if model and model.startswith(request.model)
else (model or request.model)
),
"deployment": (
model
if model and model.startswith(request.model)
else (request.model if model != request.model else None)
),
"model": model,
"timestamp": time.time(),
"parameters": request.parameters.model_dump(),
"parameters": {
**request.parameters.model_dump(),
"deployment": request.model,
},
"metrics": metrics,
"extras": request.extras,
}

self.save_log(response)
Expand Down
2 changes: 1 addition & 1 deletion llmstudio/tracking/logs/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ class LogDefault(Base):
context = Column(JSON)
provider = Column(String)
model = Column(String)
deployment = Column(String)
parameters = Column(JSON)
metrics = Column(JSON)
extras = Column(JSON)
2 changes: 1 addition & 1 deletion llmstudio/tracking/logs/schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ class LogDefaultBase(BaseModel):
context: List[Dict[str, Any]] = None
provider: str = None
model: str = None
deployment: str = None
parameters: dict = None
metrics: dict = None
extras: Optional[Dict[str, Any]] = None


class LogDefault(LogDefaultBase):
Expand Down