Skip to content

fix count circuit breaker in gateway & return 404 when context api does not match. #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

fuyuwei01
Copy link
Collaborator

…es not match

PR Type

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.1.0 milestone May 14, 2025
SkyeBeFreeman
SkyeBeFreeman previously approved these changes May 14, 2025
Copy link
Collaborator

@SkyeBeFreeman SkyeBeFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.70%. Comparing base (03124b1) to head (2f8fcc2).
Report is 1 commits behind head on hoxton.

Files with missing lines Patch % Lines
...d/plugin/gateway/context/ContextGatewayFilter.java 40.00% 6 Missing ⚠️
...nt/instrument/scg/EnhancedGatewayGlobalFilter.java 77.77% 1 Missing and 1 partial ⚠️
...teway/context/ContextGatewayPropertiesManager.java 50.00% 0 Missing and 1 partial ⚠️
...n/gateway/context/GatewayConfigChangeListener.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             hoxton    #1552      +/-   ##
============================================
+ Coverage     60.38%   63.70%   +3.31%     
  Complexity       22       22              
============================================
  Files           363      363              
  Lines          8603     8615      +12     
  Branches       1049     1054       +5     
============================================
+ Hits           5195     5488     +293     
+ Misses         2951     2657     -294     
- Partials        457      470      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@SkyeBeFreeman SkyeBeFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SkyeBeFreeman SkyeBeFreeman merged commit 0901eed into Tencent:hoxton May 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants