Skip to content

fix count circuit breaker in gateway & return 404 when context api does not match. #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

SkyeBeFreeman
Copy link
Collaborator

PR Type

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

closes #1497

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.
  • Will pull request to branch of 2022.
  • Will pull request to branch of 2021.
  • Will pull request to branch of 2020.
  • Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.1.0 milestone Apr 2, 2025
@SkyeBeFreeman SkyeBeFreeman requested a review from shedfreewu April 2, 2025 03:58
Copy link
Collaborator

@shedfreewu shedfreewu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.31%. Comparing base (9d0ec2a) to head (9eefd18).
Report is 1 commits behind head on 2022.

Files with missing lines Patch % Lines
...d/plugin/gateway/context/ContextGatewayFilter.java 45.45% 6 Missing ⚠️
...nt/instrument/scg/EnhancedGatewayGlobalFilter.java 77.77% 1 Missing and 1 partial ⚠️
...teway/context/ContextGatewayPropertiesManager.java 50.00% 0 Missing and 1 partial ⚠️
...n/gateway/context/GatewayConfigChangeListener.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2022    #1529      +/-   ##
============================================
+ Coverage     63.75%   67.31%   +3.55%     
  Complexity       20       20              
============================================
  Files           336      336              
  Lines          8118     8131      +13     
  Branches       1002     1007       +5     
============================================
+ Hits           5176     5473     +297     
+ Misses         2474     2177     -297     
- Partials        468      481      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SkyeBeFreeman SkyeBeFreeman merged commit 03338fb into Tencent:2022 Apr 2, 2025
8 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the 22/gw branch April 2, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

网关插件遗留事项
2 participants