Implement automatic trial conversion detection + add productID param #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeehut
force-pushed
the
feature/free-trials
branch
from
c39dffe to
26d75ac
Compare
Jeehut
force-pushed
the
feature/free-trials
branch
from
26d75ac to
fb34c65
Compare
|
@winsmith Just a reminder – this is still awaiting your review. 😊 |
kkostov
reviewed
Mar 27, 2025
| } | ||
| } | ||
|
|
||
| return priceValueInUSD | ||
| } | ||
|
|
||
| private static let currencyCodeToOneUSDExchangeRate: [String: Double] = [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/TelemetryDeck/PirateMetrics/issues/4.
Besides implementing the requirements in above linked task, I also updated the currency conversion rates.