Fix incorrect negative number formatting in formatStarsAmountText #1734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue in the formatStarsAmountText function where negative values were incorrectly formatted, resulting in outputs like -,127,380. The bug occurred because the negative sign from the original number was retained by the formatter, and no additional logic corrected its placement.
|
|
Thanks for this PR, Could you please resolve conflicts with base branch? And also is this PR linked with any issue number? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue in the formatStarsAmountText function where negative values were incorrectly formatted, resulting in outputs like -,127,380. The bug occurred because the negative sign from the original number was retained by the formatter, and no additional logic corrected its placement.