feat(Carousel, CenteredCarousel, Slideshow): add a11y controls, and other changes from latest carousel spec #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on withControls and withBullets settings
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 276eba7. |
|
Screenshot tests report ❌ carousel / carousel-mobile
❌ carousel / carousel-mobile-in-vivo-new
❌ carousel / carousel-mobile-with-controls-and-autoplay
❌ carousel / carousel-mobile-with-initial-active-item-1
❌ carousel / carousel-mobile-with-large-mobile-page-offset
❌ carousel / carousel-mobile-without-controls-with-bullets
❌ carousel / centered-carousel-mobile
❌ carousel / centered-carousel-mobile-with-bullets-no-controls
❌ carousel / centered-carousel-mobile-with-controls-and-autoplay
❌ carousel / centered-carousel-mobile-with-initial-active-item-1
❌ private-responsive-layout-scenarios / responsive-layout-scenarios-mobile-ios
|
|
Size stats
|
wyunreal
commented
Jun 11, 2025
| @@ -5,7 +5,7 @@ const CarouselTest = (): JSX.Element => ( | |||
| <ResponsiveLayout> | |||
| <Carousel | |||
| withBullets | |||
| items={Array.from({length: 3}, (_, idx) => ( | |||
| items={Array.from({length: 4}, (_, idx) => ( | |||
There was a problem hiding this comment.
better to have SSR test to test the base case of the carousel: having more than one page (also in desktop)
Comment on lines
-85
to
-88
| <Callout | ||
| description="Arrow controls disappear in touch devices" | ||
| asset={<IconInformationRegular />} | ||
| /> |
There was a problem hiding this comment.
don't needed as arrows will be always present, also in touch devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://www.figma.com/design/hxJvuIQQ1xf50xIOQFUZbQ/%F0%9F%94%B8-Carousel-Specs?node-id=4498-15575&t=6bLo1yGJsdBrEBkT-0