PR deploy testing #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #34 Add GitHub Action to deploy PR on GitHub Pages. * **Update `src/App.tsx`** - Change `BrowserRouter` `basename` prop to use `process.env.PUBLIC_URL`. * **Modify `.github/workflows/pr-check.yml`** - Add permissions for `pages: write` and `id-token: write`. - Add step to set up Pages using `actions/configure-pages@v4`. - Add step to upload artifact using `actions/upload-pages-artifact@v3`. - Add step to deploy to GitHub Pages using `actions/deploy-pages@v4`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/TechPaliyal/LibraryManagement/issues/34?shareId=XXXX-XXXX-XXXX-XXXX).
* **App.tsx** - Add a new route for the PR deployment URL (`/pr-deploy/:prNumber`). * **.github/workflows/pr-check.yml** - Add a new job to deploy the PR to GitHub Pages. - Update the `environment` name to include the PR number. - Update the `url` to include the PR number. * **.github/workflows/deploy.yml** - Add a new job to deploy the PR to GitHub Pages. - Update the `environment` name to include the PR number. - Update the `url` to include the PR number.
|
Add new route for PR deployment URL and update GitHub Actions workflows
|
yogeshpaliyal
had a problem deploying
to
github-pages-pr-35
GitHub Actions
Failure
yogeshpaliyal
added a commit
that referenced
this pull request
Aug 11, 2024
This reverts commit 1e42b01.
yogeshpaliyal
added a commit
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
Add GitHub Action to deploy PR on GitHub Pages.
Update
src/App.tsxBrowserRouterbasenameprop to useprocess.env.PUBLIC_URL.Modify
.github/workflows/pr-check.ymlpages: writeandid-token: write.actions/configure-pages@v4.actions/upload-pages-artifact@v3.actions/deploy-pages@v4.For more details, open the Copilot Workspace session.