-
Notifications
You must be signed in to change notification settings - Fork 44
Rename 'Is not Looped' to 'Do not loop' in ambient_generic
#260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This probably isn't a good idea, because the flag doesn't actually control whether or not the sound loops, that's defined in the sound file itself. It just changes the behavior of certain entity inputs and not having it match the sound's inbuilt loop state can cause issues. (FYI, |
|
Ideally we should find a non-negated wording too... |
I wonder if it's possible to invert the flag in FGD or at least in the Postcompiler? |
Yes, but HA can pack files, it's probably not hard to make it add loop markers into files (hopefully). |
|
That would be useful, but should be done by adding a new keyvalue to the entity instead of modifying the behavior of an existing flag. |
Oh yeah, i completely forgot how flags work |
This makes them less confusing, and also allows setting them with $fixup variables. See #260.
This makes them less confusing, and also allows setting them with $fixup variables. See #260.
|
Fwiw, GoldSrc FGDs have used the more accurate "not toggled" since 2001; somehow those changes didn't make it upstream to HL2's FGD. |
Rename looping flag in
ambient_genericto a more readable variant