Zoom fixes #29
Merged
Zoom fixes #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extracted zoom range check to isInZoomRange; fixed comments related to zoom
alejandrocoria
commented
Jul 2, 2024
| * The minimum zoom level (0 is lowest) where the polygon should be visible. | ||
| * The minimum zoom level (UIState.FULLSCREEN_ZOOM_MIN is lowest) where the overlay should be visible. |
There was a problem hiding this comment.
Is it okay to mention the constant or should I mention the value directly?
alejandrocoria
commented
Jul 2, 2024
Comment on lines
-300
to
+311
| && activeMapTypes.contains(uiState.mapType) | ||
| && (this.minZoom <= uiState.zoom && this.maxZoom >= uiState.zoom)); | ||
| && activeMapTypes.contains(uiState.mapType)); | ||
| } | ||
|
|
||
| /** | ||
| * Whether the zoom of the given context is within the zoom range of the overlay. | ||
| * | ||
| * @param uiState UIState | ||
| * @return true if the zoom of uiState is within the zoom range of the overlay | ||
| */ | ||
| public boolean isInZoomRange(UIState uiState) | ||
| { | ||
| return (this.minZoom <= uiState.zoom && this.maxZoom >= uiState.zoom); |
There was a problem hiding this comment.
I separated the zoom check so I could fix a bug later in Journeymap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.