-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add context menu "Open in Terminal" option #4213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/4.0
Are you sure you want to change the base?
Conversation
Pending tasks:
|
d0c3440
to
d4ed856
Compare
Pressing on the option 'open in terminal' does nothing on me device
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- app/src/main/AndroidManifest.xml: Language not supported
app/src/main/java/com/amaze/filemanager/ui/dialogs/OpenFolderInTerminalFragment.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For UX, the "open in terminal" button should explain something when clicked, especially if it won't actually work for most users. As it is right now it doesn't appear to even have a toast. I would add at least a small dialog though, especially because "Expected user to do all the configuration at Terminal app's own side" should be explained to the user probably in a popup dialog.
Appart from that, installing on an emulator with API 34, with TermOne Plus, I can't get the button to work, even when the forlder is accessible (and the contents are listable) from TermOne Plus.
Use dialog instead of toast to notify user that no terminal app can be found.
6b5dabc
to
2c5177a
Compare
- Fix top right menu Open in Terminal not working - Fix permission granting sequence with PermissionsActivity
Description
Adds option to open specified folder in terminal app.
Supports TermOne Plus, Termux. Jack Palovich's Android Terminal is also supported in code, but not thoroughly tested since it's no longer in development.
Expected user to do all the configuration at Terminal app's own side - like this, the most Amaze can do is check for corresponding app permission and prompt user to grant.
Issue tracker
Fixes #2666
Automatic tests
Manual tests
Done
Device: Nexus 4 emulator
OS: Android 8
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug
./gradlew spotlessCheck