Skip to content

Add Mandar (mdr) language support to LanguagesLib #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add Mandar (mdr) language support to LanguagesLib #3180

wants to merge 2 commits into from

Conversation

Rusydy
Copy link

@Rusydy Rusydy commented Apr 19, 2025

This PR is trying to solve this Issue; #3169

@Rusydy Rusydy force-pushed the dev branch 6 times, most recently from d5d661b to 8f73b79 Compare May 11, 2025 19:41
@Rusydy
Copy link
Author

Rusydy commented May 11, 2025

Hi @jiru @trang

Would you mind reviewing this PR?

@jiru
Copy link
Member

jiru commented May 16, 2025

Hi Rusydy, thank you for your PR. Here is my review.

  1. Your PR somehow includes changes that are not related (maintenance message changes that were implemented lately). Please try to remove these changes from the PR, or maybe start over after syncing your fork. If necessary, you can close this PR and open a new one.
  2. Why is your flag so different from the one mentioned in Mandar (mdr) #3169, which looks like this?
  3. Your flag size is 27px per 20px. Please try to adjust the size to 30px per 20px instead. If you don’t know how to do that, we may as well merge the PR as-is and I’ll fix the flag in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rusydy @jiru