Skip to content

fix(router-core): ensure rewrite basepath applies consistently #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
+122 −19
Open

fix(router-core): ensure rewrite basepath applies consistently #5202

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
23be5f9
fix(router-core): ensure href proterty uses rewritten URL in buildLoc…
leesb971204 Sep 24, 2025
593cb78
fix(router-core): rewrite examples in RouterOptions for improved clarity
leesb971204 Sep 24, 2025
508303a
Merge remote-tracking branch 'upstream/main' into fix/buildlocation-h…
leesb971204 Sep 25, 2025
2b831cf
test(react-router): add tests for browser url includes basepath on ro…
leesb971204 Sep 26, 2025
a9dbeb7
Merge remote-tracking branch 'upstream/main' into fix/buildlocation-h…
leesb971204 Sep 26, 2025
b9a4ce3
Merge remote-tracking branch 'upstream/main' into fix/buildlocation-h…
leesb971204 Sep 29, 2025
e900a66
Merge branch 'main' into fix/buildlocation-href-rewrite
leesb971204 Sep 30, 2025
a161948
fix(router): use publicHref for URL comparisons in Transitioner and r…
leesb971204 Sep 30, 2025
977587d
trigger CI
leesb971204 Sep 30, 2025
7f764e8
trigger CI
leesb971204 Oct 1, 2025
bcff760
ci: apply automated fixes
autofix-ci[bot] Oct 1, 2025
9215441
fix(router): revert the href value
leesb971204 Oct 2, 2025
8ad0f67
Merge branch 'main' into fix/buildlocation-href-rewrite
leesb971204 Oct 2, 2025
918e51e
trigger CI
leesb971204 Oct 2, 2025
a22766a
fix(router): revert handle server redirect by #5330
leesb971204 Oct 2, 2025
5f52ff8
test(react-router): update router configuration to use basepath direc…
leesb971204 Oct 7, 2025
710f5cc
fix(react-router): handle cross-origin navigation in Transitioner com…
leesb971204 Oct 10, 2025
e8757e3
Merge branch 'main' into fix/buildlocation-href-rewrite
leesb971204 Oct 10, 2025
6aa38f1
fix(solid-router): handle cross-origin navigation in Transitioner com…
leesb971204 Oct 10, 2025
8d3694b
refactor: improve cross-origin navigation handle
leesb971204 Oct 13, 2025
9251031
Merge remote-tracking branch 'upstream/main' into fix/buildlocation-h…
leesb971204 Oct 13, 2025
bc36e9d
refactor(router-core): update location building for navigate
leesb971204 Oct 14, 2025
6a014f1
chore: fix fail CI
leesb971204 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/router-core/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,7 +1682,7 @@ export class RouterCore<
return {
publicHref:
rewrittenUrl.pathname + rewrittenUrl.search + rewrittenUrl.hash,
href: fullPath,
href: rewrittenUrl.href.replace(rewrittenUrl.origin, ''),
url: rewrittenUrl.href,
pathname: nextPathname,
search: nextSearch,
Expand Down
Loading