Upgrade Ktor version to stable v3 #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Taewan-P
commented
Oct 26, 2024
Taewan-P
commented
- This PR will be ready when feat(ktor): update to stable v3 aallam/openai-kotlin#389 is successfully published to releases.
- Migrates Ktor 2.x to 3.0. This changes the way of implementing Anthropic API request that uses Server Sent Event since Ktor 3.0 natively supports SSE.
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- app/src/main/kotlin/dev/chungjungsoo/gptmobile/data/network/AnthropicAPIImpl.kt: Language not supported
- app/src/main/kotlin/dev/chungjungsoo/gptmobile/data/network/NetworkClient.kt: Language not supported
|
Build complete! Here's the debug APK: https://github.com/Taewan-P/gpt_mobile/actions/runs/11986670558/artifacts/2227870712 |
|
This PR cannot be merged until google-gemini/deprecated-generative-ai-android#222 is solved due to dependency issues. Or implementing Gemini API with Ktor V3 and removing the generative ai SDK can also solve the build error. |
|
This will be included in the app rework. Changing the base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.