Skip to content

Conversation

ankitkumar1302
Copy link

@ankitkumar1302 ankitkumar1302 commented Oct 1, 2025

CREATE MATERIAL 3 THEME MIGRATION FOR THE PROJECT

Summary by CodeRabbit

  • New Features
    • Refined theming with updated typography and shapes for a more polished look.
  • Style
    • Consistent, theme-based colors for chat bubbles and top app bars; clearer selection mode styling on Home.
  • Bug Fixes
    • Prevented a potential crash when platform data is unavailable in Settings.
  • Documentation
    • Simplified README by hiding unpublished sections; added metadata guide; generalized Code of Conduct contact info.
  • Chores
    • Updated app identity and versioning; app package renamed and version set to 1.0.0.

- Added proper Material 3 Typography scale with all text styles (display, headline, title, body, label)
- Added Material 3 Shapes scale (extraSmall to extraLarge)
- Integrated ExtendedColorScheme with CompositionLocal for custom theme colors
- Fixed ChatBubble cards to use CardDefaults instead of manual CardColors construction
- Removed hardcoded colors from TopAppBar in all setting screens
- Improved HomeScreen TopAppBar to use proper Material 3 defaults while maintaining selection mode styling
- Fixed nullable platform bug in PlatformSettingScreen
- Audited dark mode implementation - all colors properly use MaterialTheme.colorScheme

All changes maintain backward compatibility and improve theme consistency across light and dark modes.
Copy link

coderabbitai bot commented Oct 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates package identifiers and versioning in the Android module, adds explicit Material 3 theme shapes and typography, extends theming with a new CompositionLocal for extended colors and integrates shapes into MaterialTheme. Multiple UI screens switch to default/top-app-bar color behaviors and revised card colors. Documentation and README sections are pruned or commented out. A metadata README is added.

Changes

Cohort / File(s) Summary
Documentation cleanup
CODE_OF_CONDUCT.md, README.md, metadata/README.md
Removed hard-coded contact email with placeholder comment; hid various README sections via HTML comments and adjusted contribution text; added metadata README outlining store listing placeholders and update steps.
Android config update
app/build.gradle.kts
Changed namespace and applicationId to dev.ankitkumar1302.gptmobile; reset versionCode to 1 and versionName to 1.0.0.
Theme system enhancements
app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/theme/Shapes.kt, .../theme/Type.kt, .../theme/Theme.kt
Added AppShapes with rounded corners; replaced Typography() with full explicit M3 text styles; introduced LocalExtendedColors CompositionLocal, updated GPTMobileTheme signature to include themeMode, provided extended colors via CompositionLocalProvider, and injected shapes into MaterialTheme.
UI color/theming adjustments
.../ui/chat/ChatBubble.kt, .../ui/home/HomeScreen.kt, .../ui/setting/AboutScreen.kt, .../ui/setting/LicenseScreen.kt, .../ui/setting/PlatformSettingScreen.kt, .../ui/setting/SettingScreen.kt
Switched Card colors to CardDefaults.cardColors; conditional TopAppBar colors in selection mode on HomeScreen; removed explicit TopAppBar color overrides in multiple screens; added null-safe check for platform name in PlatformSettingScreen enablement.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor App
  participant Theme as GPTMobileTheme
  participant Local as CompositionLocalProvider
  participant M3 as MaterialTheme
  participant Screens as UI Screens

  App->>Theme: Call GPTMobileTheme(dynamicTheme, themeMode) { content }
  Theme->>Theme: Determine useDarkTheme + extendedColors
  Theme->>Local: Provide LocalExtendedColors = extendedColors
  Local->>M3: MaterialTheme(colorScheme, typography, shapes=AppShapes)
  M3-->>Screens: Expose theme tokens (colors, typography, shapes)
  note over Theme,M3: Extended colors vary by themeMode/dynamicTheme
  Screens->>Screens: Use defaults for TopAppBar/Card colors (updated usages)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I nibbled the badges, hid stars in the hay,
Painted new shapes where the corners lay.
Packed fresh colors in a pocket so light,
Cards and bars now glow just right.
With a hop to v1.0.0, I cheer—
“Ship-shape styling, carrot-clear!” 🥕✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40e385e and 538ab29.

📒 Files selected for processing (13)
  • CODE_OF_CONDUCT.md (1 hunks)
  • README.md (4 hunks)
  • app/build.gradle.kts (1 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/theme/Shapes.kt (1 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/theme/Theme.kt (4 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/theme/Type.kt (1 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/ui/chat/ChatBubble.kt (3 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/ui/home/HomeScreen.kt (1 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/ui/setting/AboutScreen.kt (0 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/ui/setting/LicenseScreen.kt (0 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/ui/setting/PlatformSettingScreen.kt (1 hunks)
  • app/src/main/kotlin/dev/chungjungsoo/gptmobile/presentation/ui/setting/SettingScreen.kt (0 hunks)
  • metadata/README.md (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ankitkumar1302 ankitkumar1302 deleted the material3-theme-migration branch October 1, 2025 18:14
@ankitkumar1302 ankitkumar1302 restored the material3-theme-migration branch October 1, 2025 18:15
@ankitkumar1302 ankitkumar1302 deleted the material3-theme-migration branch October 1, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant