-
-
Notifications
You must be signed in to change notification settings - Fork 103
Material3 theme migration #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material3 theme migration #219
Conversation
…iginal author references
- Added proper Material 3 Typography scale with all text styles (display, headline, title, body, label) - Added Material 3 Shapes scale (extraSmall to extraLarge) - Integrated ExtendedColorScheme with CompositionLocal for custom theme colors - Fixed ChatBubble cards to use CardDefaults instead of manual CardColors construction - Removed hardcoded colors from TopAppBar in all setting screens - Improved HomeScreen TopAppBar to use proper Material 3 defaults while maintaining selection mode styling - Fixed nullable platform bug in PlatformSettingScreen - Audited dark mode implementation - all colors properly use MaterialTheme.colorScheme All changes maintain backward compatibility and improve theme consistency across light and dark modes.
Caution Review failedThe pull request is closed. WalkthroughUpdates package identifiers and versioning in the Android module, adds explicit Material 3 theme shapes and typography, extends theming with a new CompositionLocal for extended colors and integrates shapes into MaterialTheme. Multiple UI screens switch to default/top-app-bar color behaviors and revised card colors. Documentation and README sections are pruned or commented out. A metadata README is added. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor App
participant Theme as GPTMobileTheme
participant Local as CompositionLocalProvider
participant M3 as MaterialTheme
participant Screens as UI Screens
App->>Theme: Call GPTMobileTheme(dynamicTheme, themeMode) { content }
Theme->>Theme: Determine useDarkTheme + extendedColors
Theme->>Local: Provide LocalExtendedColors = extendedColors
Local->>M3: MaterialTheme(colorScheme, typography, shapes=AppShapes)
M3-->>Screens: Expose theme tokens (colors, typography, shapes)
note over Theme,M3: Extended colors vary by themeMode/dynamicTheme
Screens->>Screens: Use defaults for TopAppBar/Card colors (updated usages)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CREATE MATERIAL 3 THEME MIGRATION FOR THE PROJECT
Summary by CodeRabbit