[TASK] Establish proper API to set template layout #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2b
force-pushed
the
task/templateLayoutVariable
branch
3 times, most recently
from
481d724 to
b511013
Compare
The `ParsingState` now provides a proper method to set the layout of a template during parsing/compilation. Previously, the magic variable name `layoutName` has been used for that purpose, but with the new `nodeInitializedEvent` we can now access the `ParsingState` object directly. The usage of the old variable name has been deprecated and will no longer be evaluated with Fluid v5. Its main usage besides the `<f:layout>` ViewHelper (see above) has been the cache warmup command, which will receive a more straightforward implementation with Fluid v5.
s2b
force-pushed
the
task/templateLayoutVariable
branch
from
b511013 to
540177b
Compare
|
TYPO3 Core CI is green (apart from composer integrity): https://review.typo3.org/c/Packages/TYPO3.CMS/+/89518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ParsingStatenow provides a proper method to set thelayout of a template during parsing/compilation. Previously, the
magic variable name
layoutNamehas been used for thatpurpose, but with the new
nodeInitializedEventwe can nowaccess the
ParsingStateobject directly.The usage of the old variable name has been deprecated and
will no longer be evaluated with Fluid v5. Its main usage besides
the
<f:layout>ViewHelper (see above) has been the cachewarmup command, which will receive a more straightforward
implementation with Fluid v5.