-
Notifications
You must be signed in to change notification settings - Fork 0
Add sdJwt presentation #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b2774ed
f355664
500c785
8f8f73e
df11201
8676c49
c9d2e6f
143dea7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,7 @@ import eu.europa.ec.eudi.openid4vci.* | |
*/ | ||
internal data class DefaultOffer( | ||
@JvmSynthetic val credentialOffer: CredentialOffer, | ||
@JvmSynthetic val credentialConfigurationFilter: CredentialConfigurationFilter = CredentialConfigurationFilter.MsoMdocFormatFilter, | ||
@JvmSynthetic val credentialConfigurationFilter: CredentialConfigurationFilter = CredentialConfigurationFilter.SdJwtOrMsoMdocFormatFilter, | ||
) : Offer { | ||
|
||
private val issuerMetadata: CredentialIssuerMetadata | ||
|
@@ -41,8 +41,9 @@ internal data class DefaultOffer( | |
|
||
override val offeredDocuments: List<Offer.OfferedDocument> | ||
get() = issuerMetadata.credentialConfigurationsSupported | ||
.filterKeys { it in credentialOffer.credentialConfigurationIdentifiers } | ||
.filterValues { credentialConfigurationFilter(it) } | ||
// TODO temporarily removed to make it work | ||
//.filterKeys { it in credentialOffer.credentialConfigurationIdentifiers } | ||
//.filterValues { credentialConfigurationFilter(it) } | ||
Comment on lines
+45
to
+46
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Uncommented code, remove? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still uncommented. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hab einen Kommentar drüber damit man weiß, dass das wieder rein muss |
||
.map { (id, conf) -> DefaultOfferedDocument(id, conf) } | ||
|
||
override val txCodeSpec: Offer.TxCodeSpec? | ||
|
@@ -92,7 +93,7 @@ internal val CredentialConfiguration.name: String | |
internal val CredentialConfiguration.docType: String | ||
@JvmSynthetic get() = when (this) { | ||
is MsoMdocCredential -> docType | ||
is SdJwtVcCredential -> "eu.europa.ec.eudi.pid_jwt_vc_json" | ||
is SdJwtVcCredential -> "eu.europa.ec.eudi.pid.1" | ||
else -> "unknown" | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kurze Frage:
Waren unsere ID's jetzt gesynced, so dass das funktionieren kann?
(Oder nicht und wir müssen das noch einmal anpassen?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Die Id´s sind nicht synced, aber wir gehen davon aus, dass wir nur ein SdJwt haben können und löschen das wenn irgendein Mdoc gelöscht wird. Das ist good enough würde ich sagen. Wir sollten in die Lib noch einen Check einbauen, dass man nicht mehr als ein Pid haben kann, damit hier nichts kaputt gehen kann