xtypullrequest #65
Open
xtypullrequest #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
787809089
commented
Nov 16, 2018
787809089
commented
Nov 16, 2018
| class activityList(APIView): | ||
| #获取活动列表 | ||
| def get(self): | ||
| # if self.request.user.is_authenticated(): |
787809089
commented
Nov 16, 2018
| return activity_List | ||
| # else: | ||
| # raise ValidateError('Please login!') | ||
|
|
There was a problem hiding this comment.
作者将活动列表内的post接口额外写到了activityDelete类中。
787809089
commented
Nov 16, 2018
| activity = Activity.objects.get(id__exact = id) | ||
| except: | ||
| raise ValidateError("ID does not exit!") | ||
| if activity: |
787809089
commented
Nov 16, 2018
| self.check_input('id') | ||
| id = self.input['id'] | ||
| try: | ||
| activity = Activity.objects.get(id=id) |
787809089
commented
Nov 16, 2018
| activity.book_end = self.input['bookEnd'] | ||
| activity.total_tickets = self.input['totalTickets'] | ||
| activity.status = self.input['status'] | ||
|
|
|
整个项目关于登录状态的判断都被注释掉了，没有实现登录状态判断；测试通过后冗余的代码应该删除，不要以注释的方式保留在代码中；admin部分查找活动和票调用的都是get()函数，但get只返回第一个符合条件的对象，有几处需要找到所有符合条件的对象的地方应该用filter()函数。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.