2016013243 #56
Open
2016013243 #56
+792
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzw28
commented
Nov 16, 2018
| auth.logout(self.request) | ||
| except: | ||
| raise ValidateError("Fail to logout!") | ||
|
|
There was a problem hiding this comment.
logout() doesn’t throw any errors if the user wasn’t logged in.
| activity.save() | ||
| else: | ||
| raise ValidateError("Activity is already deleted!") | ||
|
|
| ValidateError('Ticket is invalid') | ||
| except: | ||
| ValidateError('Fail to Checkin!') | ||
|
|
| raise ValidateError('无效学号!') | ||
| else: | ||
| raise ValidateError('无效学号!') | ||
|
|
| 'Url':ticket, | ||
| 'PicUrl':activity.pic_url, | ||
| }) | ||
|
|
There was a problem hiding this comment.
代码重复程度高。点击按钮和文本指令只有输入部分有区别，不建议完全分开。
| 'PicUrl':ticket.activity.pic_url, | ||
| }) | ||
| return self.reply_text('对不起，当前没有已经购买的有效票') | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.