Suggestion/ Minor API changes #616
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er into minor-player-API-changes * 'develop' of github.com:THEOplayer/react-native-theoplayer: (65 commits) 9.10.0 Update changelog Add changelog entry Update state's currentTime on seeking seeked events Fix seeking seeked event types Add changelog entry Fix attaching seeked handler Update iOS github action Update connector list Remove unsused import (Platform) Remove $ from copyable code blocks Add `,` in "features" array react-native init is deprecated Starting from v0.71 Typescript is used by default Add changelog entry Do not reparent on transitioning Update layout on transition Fix player fullscreen layout 9.9.1 Prepare changelog for release update example pod lock Add changelog entry ... # Conflicts: # src/internal/THEOplayerView.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We had to change access modifiers for a few things in our patch to emit onPlayerReady when we restore the existing player instance back to JS tree.
Also we added
customPlayerRendercallback to the API as we use it to show something else instead of the THEO player view (also used for the new floating component implementation).I totally understand this code might look too custom and I'm not really sure which of the suggestions you'd want/can incorporate into your codebase so I decided to split them in atomic commits. Please revert everything you don't like / can't provide due to guidelines or change naming as you wish 🙏 And thank you.