Skip to content

Bugfix/conviva/ios start and stop when paused #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix/conviva/ios start and stop when paused #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a63c2
Allow stopAndStartNewSession on a paused player
wvanhaevre Oct 16, 2025
e92d276
add changeset
wvanhaevre Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ten-ears-count.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@theoplayer/react-native-analytics-conviva': patch
---

Fixed an issue where on iOS the stopAndStartNewSession was blocked when the player was in a paused state.
3 changes: 1 addition & 2 deletions conviva/ios/THEOplayerConvivaRCTConvivaAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ class THEOplayerConvivaRCTConvivaAPI: NSObject, RCTBridgeModule {
log("stopAndStartNewSession triggered")
DispatchQueue.main.async {
if let connector = self.connectors[node],
let contentInfo = metadata as? [String: Any],
self.player(for: node)?.paused == false {
let contentInfo = metadata as? [String: Any] {
log("reporting stopAndStartNewSession")
connector.stopAndStartNewSession(contentInfo: contentInfo)
}
Expand Down
Loading