-
Notifications
You must be signed in to change notification settings - Fork 15
V1 private api #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BrianMichell
wants to merge
55
commits into
TGSAI:v1
Choose a base branch
from
BrianMichell:v1_private_api
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V1 private api #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1 #557 +/- ##
==========================================
+ Coverage 84.32% 91.54% +7.22%
==========================================
Files 46 70 +24
Lines 2194 3937 +1743
Branches 305 273 -32
==========================================
+ Hits 1850 3604 +1754
+ Misses 301 258 -43
- Partials 43 75 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think this is fine to start pushing forward @tasansal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should remain a draft until #553 is reviewed and approved/rejected.
Fully addresses
FactoryBuilderBegins to add some documentation for the builder.
Partially addresses