Skip to content

V1 private api #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 55 commits into
base: v1
Choose a base branch
from
Open

V1 private api #557

wants to merge 55 commits into from

Conversation

BrianMichell
Copy link
Collaborator

This PR should remain a draft until #553 is reviewed and approved/rejected.

Fully addresses

  • DIY Factory Builder
    Begins to add some documentation for the builder.
  • JSON Serialization

Partially addresses

  • Template Factory

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 90.65041% with 92 lines in your changes missing coverage. Please review.

Project coverage is 91.54%. Comparing base (0195bb1) to head (006f614).
Report is 147 commits behind head on v1.

Files with missing lines Patch % Lines
src/mdio/core/v1/_serializer.py 69.93% 31 Missing and 12 partials ⚠️
src/mdio/core/v1/factory.py 71.01% 19 Missing and 1 partial ⚠️
tests/unit/test_schema.py 95.51% 3 Missing and 8 partials ⚠️
src/mdio/core/v1/_overloads.py 74.28% 8 Missing and 1 partial ⚠️
src/mdio/core/v1/builder.py 94.11% 5 Missing and 2 partials ⚠️
src/mdio/schemas/core.py 94.11% 0 Missing and 1 partial ⚠️
tests/integration/test_v1_serialization.py 97.56% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v1     #557      +/-   ##
==========================================
+ Coverage   84.32%   91.54%   +7.22%     
==========================================
  Files          46       70      +24     
  Lines        2194     3937    +1743     
  Branches      305      273      -32     
==========================================
+ Hits         1850     3604    +1754     
+ Misses        301      258      -43     
- Partials       43       75      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BrianMichell
Copy link
Collaborator Author

I think this is fine to start pushing forward @tasansal

@BrianMichell BrianMichell marked this pull request as ready for review June 16, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants