Fixes to seeking and auto restore#4347

Merged

SuuperW merged 29 commits intoTASEmulators:masterfrom

SuuperW:auto_restore

Jun 21, 2025

Commits on Jun 15, 2025

rename variable
SuuperW
committed

Commits on Jun 16, 2025

move safety check inside StartSeeking, instead of making caller responsible
SuuperW
committed
tastudio should own tastudio logic
SuuperW
committed
Make TAStudio take ownership of its own seeking logic and simplify some code, fixing a few bugs:
SuuperW
committed
Remove obsolete conditional.
SuuperW
committed
Fix: Mouse drag seeking was broken while seeking. (It would not change the target seek frame until prior seek had completed.)
SuuperW
committed
GoToFrame's "future frame" cases were just buggy versions of the normal case. So just use the code of StartAtNearestFrameAndEmulate instead. Fixes multiple bugs when seeking to frames past the end …
SuuperW
committed
Fix: modifier key + right click would jump to the last edited frame (even if this right click made no edits)
SuuperW
committed
simplify a bit of logic
SuuperW
committed
Fix: Clicking on an axis value while in axis editing mode would disable recording mode, regardless of whether an edit was made.
SuuperW
committed
Windows weirdness: MouseUp event is not guaranteed to be raised.
SuuperW
committed
Replace some auto restore code with something simpler. Fixes auto-restore for right-click edits.
SuuperW
committed
Revert commit a1c8c4ed3a676954358cb493efc878436bd43a4e. It was always pointless because it didn't fix the issue it was supposed to fix, and the later commit that actually fixes it was all that was …
SuuperW
committed
Convert remaining auto-restore points to the new system. Also include refreshing in FrameEdited. Fixes more bugs.
SuuperW
committed
inline function that is only called from one place
SuuperW
committed
Fix: turbo seek did not work when navigating while unpaused
SuuperW
committed
Call our new FrameEdited thing for auto restore whenever greenzone is invalidated, instead of manually calling at each edit point. This fixes auto-restore for undo/redo actions.
SuuperW
committed
Fix: Greenzone would be invalidated if pasting or clearing a frame even if no change was made.
SuuperW
committed
Fix: Seeks from Lua would freeze the UI and not return to Lua until the seek has completed, making the Lua script unable to see the frames during the seek.
SuuperW
committed
add hotkey for go to green arrow (manual restore position)
SuuperW
committed
Feature, from TASeditor: middle-click resumes seek if seek is in progress. This might be what StartSeeking's fromMiddleClick parameter (removed in last commit) was attempting to do.
SuuperW
committed
TAStudio should own TAStudio logic. Fix: The green arrow would move when making multiple edits with auto-restore off if the edit caused a seek of >1 frame.
SuuperW
committed
Deprecate client.seekframe. This had the same issue as tastudio.setplayback, freezing the UI. Since seekframe cannot go backwards, updating it to return immediately results in it doing absolutely n…
SuuperW
committed
Fix: Manual seeks past the end of the movie were not respected if AutoPause was on.
SuuperW
committed
Show seek progress bar if we are seeking more than 1 frame. We don't know how long it's going to take! Also if the user ends up pausing there should be a visual indication of seeking.
SuuperW
committed
Remove redundant code.
SuuperW
committed
Fix: tastudio.setplayback would refuse to seek past the end of a movie
SuuperW
committed
Fix: Using tastudio.setplayback to seek to a non-existent marker would permanently suppress Lua.
SuuperW
committed

Commits on Jun 21, 2025

Safety for any custom or future tools that want to use this.
SuuperW
committed