Skip to content

Conversation

@MJC598
Copy link
Contributor

@MJC598 MJC598 commented May 1, 2025

Breaking out the source files so that this library can compile with 3rd party libraries that do not have effective transitive linking.

@MJC598 MJC598 added the bug Something isn't working label May 1, 2025
@MJC598 MJC598 requested a review from ddbaptiste May 1, 2025 18:45
@MJC598 MJC598 self-assigned this May 1, 2025
Copy link
Contributor

@ddbaptiste ddbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source code looks good to me. Approved, pending CI fixes.

Copy link
Contributor

@ddbaptiste ddbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving per discussion.

@MJC598 MJC598 merged commit febef56 into main May 1, 2025
4 checks passed
@MJC598 MJC598 deleted the feature/source-breakout branch May 1, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants