Feature/293 convert moduledefinition #327
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roundtrip conversion of ModuleDefinition to Component and back again (#293 )
Current test case focuses on a simple ModuleDefinition. Future PRs will expand test coverage to child classes, e.g., Interaction, FunctionalComponent, etc.
Test files were created synthetically using a pySBOL script (as opposed to representing an SBOL file found "in the wild"). Question: Do we want to check in this script? (It may be helpful for building out other representations to use as test cases).
While working on this, I noticed there's an annoying workaround that is required for our current round-trip tests to work. In order for the triples in the original file to exactly match the triples in the round-tripped file, we have to artificially introduce a triple with
backport:sbol3namespace
in the test file (seeSBOL-utilities/test/test_files/sbol_3to2_moduledefinition.xml
Line 4 in 8645fbe