Skip to content

Feature/293 convert moduledefinition #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

bbartley
Copy link
Collaborator

@bbartley bbartley commented Jun 15, 2025

Roundtrip conversion of ModuleDefinition to Component and back again (#293 )

Current test case focuses on a simple ModuleDefinition. Future PRs will expand test coverage to child classes, e.g., Interaction, FunctionalComponent, etc.

Test files were created synthetically using a pySBOL script (as opposed to representing an SBOL file found "in the wild"). Question: Do we want to check in this script? (It may be helpful for building out other representations to use as test cases).

While working on this, I noticed there's an annoying workaround that is required for our current round-trip tests to work. In order for the triples in the original file to exactly match the triples in the round-tripped file, we have to artificially introduce a triple with backport:sbol3namespace in the test file (see

<backport:sbol3namespace rdf:resource="http://synbiohub.bbn.com"/>
). Making a note of it here, because we may want to file an issue later

@bbartley bbartley requested a review from jakebeal June 15, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant