-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add banner sunsetting Renku Legacy #3721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3721.dev.renku.ch |
@@ -23,6 +23,7 @@ import { Button, ButtonGroup, Col, Row, Table } from "reactstrap"; | |||
import { ContainerWrap } from "../../App"; | |||
import { Loader } from "../../components/Loader"; | |||
import LoginAlert from "../../components/loginAlert/LoginAlert"; | |||
import SunsetBanner from "../../features/projectsV2/shared/SunsetV1Banner.tsx"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import SunsetBanner from "../../features/projectsV2/shared/SunsetV1Banner.tsx"; | |
import SunsetBanner from "../../features/projectsV2/shared/SunsetV1Banner"; |
@@ -35,6 +35,7 @@ import ProgressIndicator, { | |||
import useAppDispatch from "../../../utils/customHooks/useAppDispatch.hook"; | |||
import useLegacySelector from "../../../utils/customHooks/useLegacySelector.hook"; | |||
import { Url } from "../../../utils/helpers/url"; | |||
import SunsetBanner from "../../projectsV2/shared/SunsetV1Banner.tsx"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import SunsetBanner from "../../projectsV2/shared/SunsetV1Banner.tsx"; | |
import SunsetBanner from "../../projectsV2/shared/SunsetV1Banner"; |
import { WarnAlert } from "../../../components/Alert.jsx"; | ||
import { ABSOLUTE_ROUTES } from "../../../routing/routes.constants.ts"; | ||
import SunsetV1Button from "./SunsetV1Button.tsx"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { WarnAlert } from "../../../components/Alert.jsx"; | |
import { ABSOLUTE_ROUTES } from "../../../routing/routes.constants.ts"; | |
import SunsetV1Button from "./SunsetV1Button.tsx"; | |
import { WarnAlert } from "../../../components/Alert"; | |
import { ABSOLUTE_ROUTES } from "../../../routing/routes.constants"; | |
import SunsetV1Button from "./SunsetV1Button"; |
@@ -39,6 +39,7 @@ import ProgressIndicator, { | |||
ProgressType, | |||
} from "../../../components/progress/Progress"; | |||
import { useCoreSupport } from "../../../features/project/useProjectCoreSupport"; | |||
import SunsetBanner from "../../../features/projectsV2/shared/SunsetV1Banner.tsx"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import SunsetBanner from "../../../features/projectsV2/shared/SunsetV1Banner.tsx"; | |
import SunsetBanner from "../../../features/projectsV2/shared/SunsetV1Banner"; |
d3d86c9
to
b7dc4b7
Compare
export default function SunsetBanner() { | ||
return ( | ||
<WarnAlert> | ||
<h4>New project creation ends July 15</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true only on RenkuLab.io. How do we expect this change to be released on other Renku platforms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this would apply to all Renku deployments. Could you clarify what you mean by "other Renku platforms"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all Renku deployments will follow our schedule wrt. release rollouts and when the project creation in Renku Legacy will be blocked. It is down to Renku admins to decide when this happens; we do not have remote control over v1 project creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is OK
Tearing down the temporary RenkuLab deplyoment for this PR. |
Pr to add warning banner about deprecation of project/dataset creation in Legacy after July 15, 2025
/deploy renku=leafty/build-react-router-v7