Skip to content

feat: add banner sunsetting Renku Legacy #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2025

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Jun 6, 2025

Pr to add warning banner about deprecation of project/dataset creation in Legacy after July 15, 2025

Screenshot 2025-06-16 at 10 23 00

/deploy renku=leafty/build-react-router-v7

@andre-code andre-code temporarily deployed to renku-ci-ui-3721 June 6, 2025 10:36 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Jun 6, 2025

You can access the deployment of this PR at https://renku-ci-ui-3721.dev.renku.ch

@andre-code andre-code temporarily deployed to renku-ci-ui-3721 June 9, 2025 20:09 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-3721 June 16, 2025 06:26 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-3721 June 16, 2025 06:55 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-3721 June 16, 2025 07:04 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-3721 June 16, 2025 07:21 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-3721 June 16, 2025 08:12 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-3721 June 16, 2025 08:23 — with GitHub Actions Inactive
@andre-code andre-code marked this pull request as ready for review June 16, 2025 08:52
@andre-code andre-code requested a review from a team as a code owner June 16, 2025 08:52
@@ -23,6 +23,7 @@ import { Button, ButtonGroup, Col, Row, Table } from "reactstrap";
import { ContainerWrap } from "../../App";
import { Loader } from "../../components/Loader";
import LoginAlert from "../../components/loginAlert/LoginAlert";
import SunsetBanner from "../../features/projectsV2/shared/SunsetV1Banner.tsx";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import SunsetBanner from "../../features/projectsV2/shared/SunsetV1Banner.tsx";
import SunsetBanner from "../../features/projectsV2/shared/SunsetV1Banner";

@@ -35,6 +35,7 @@ import ProgressIndicator, {
import useAppDispatch from "../../../utils/customHooks/useAppDispatch.hook";
import useLegacySelector from "../../../utils/customHooks/useLegacySelector.hook";
import { Url } from "../../../utils/helpers/url";
import SunsetBanner from "../../projectsV2/shared/SunsetV1Banner.tsx";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import SunsetBanner from "../../projectsV2/shared/SunsetV1Banner.tsx";
import SunsetBanner from "../../projectsV2/shared/SunsetV1Banner";

Comment on lines 4 to 6
import { WarnAlert } from "../../../components/Alert.jsx";
import { ABSOLUTE_ROUTES } from "../../../routing/routes.constants.ts";
import SunsetV1Button from "./SunsetV1Button.tsx";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { WarnAlert } from "../../../components/Alert.jsx";
import { ABSOLUTE_ROUTES } from "../../../routing/routes.constants.ts";
import SunsetV1Button from "./SunsetV1Button.tsx";
import { WarnAlert } from "../../../components/Alert";
import { ABSOLUTE_ROUTES } from "../../../routing/routes.constants";
import SunsetV1Button from "./SunsetV1Button";

@@ -39,6 +39,7 @@ import ProgressIndicator, {
ProgressType,
} from "../../../components/progress/Progress";
import { useCoreSupport } from "../../../features/project/useProjectCoreSupport";
import SunsetBanner from "../../../features/projectsV2/shared/SunsetV1Banner.tsx";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import SunsetBanner from "../../../features/projectsV2/shared/SunsetV1Banner.tsx";
import SunsetBanner from "../../../features/projectsV2/shared/SunsetV1Banner";

export default function SunsetBanner() {
return (
<WarnAlert>
<h4>New project creation ends July 15</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true only on RenkuLab.io. How do we expect this change to be released on other Renku platforms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would apply to all Renku deployments. Could you clarify what you mean by "other Renku platforms"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all Renku deployments will follow our schedule wrt. release rollouts and when the project creation in Renku Legacy will be blocked. It is down to Renku admins to decide when this happens; we do not have remote control over v1 project creation.

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is OK

@andre-code andre-code merged commit c75f227 into main Jun 17, 2025
33 of 36 checks passed
@andre-code andre-code deleted the andrea/banner-sunsetting-legacy branch June 17, 2025 07:04
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants