chore: update first-time legacy message #3712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokroskar
had a problem deploying
to
renku-ci-ui-3712
GitHub Actions
Failure
|
You can access the deployment of this PR at https://renku-ci-ui-3712.dev.renku.ch |
rokroskar
force-pushed
the
000-update-v1-first-time-message
branch
from
f868d74 to
b0485c2
Compare
rokroskar
temporarily deployed
to
renku-ci-ui-3712
GitHub Actions
Inactive
rokroskar
force-pushed
the
000-update-v1-first-time-message
branch
from
b0485c2 to
c9ac242
Compare
rokroskar
temporarily deployed
to
renku-ci-ui-3712
GitHub Actions
Inactive
rokroskar
force-pushed
the
000-update-v1-first-time-message
branch
from
c9ac242 to
778fd4f
Compare
rokroskar
temporarily deployed
to
renku-ci-ui-3712
GitHub Actions
Inactive
rokroskar
had a problem deploying
to
renku-ci-ui-3712
GitHub Actions
Error
rokroskar
force-pushed
the
000-update-v1-first-time-message
branch
from
778fd4f to
a7f13fc
Compare
rokroskar
had a problem deploying
to
renku-ci-ui-3712
GitHub Actions
Error
rokroskar
force-pushed
the
000-update-v1-first-time-message
branch
from
a7f13fc to
06211c6
Compare
rokroskar
temporarily deployed
to
renku-ci-ui-3712
GitHub Actions
Inactive
andre-code
previously requested changes
Jun 2, 2025
There was a problem hiding this comment.
Thanks, @rokroskar, for checking this and adding the missing texts! I just left a couple of small, easy code suggestions.
| title="search" | ||
| url="/v1/search" | ||
| title="Community Portal" | ||
| url="https://renku.notion.site/Renku-Community-Portal-2a154d7d30b24ab8a5968c60c2592d87" |
There was a problem hiding this comment.
Please use the RENKU_2_COMMUNITY_PORTAL constant from client/src/utils/constants/Docs.js
| title="create a new project" | ||
| url="/v1/projects/new" | ||
| title="hands-on tutorial" | ||
| url="https://renku.notion.site/Hands-On-Tutorial-1a50df2efafc800f8554e30fd7458fa6" |
There was a problem hiding this comment.
Please define this value as a constant in client/src/utils/constants/Docs.js
e.g. RENKU_2_HANDS_ON_TUTORIAL
leafty
previously approved these changes
Jun 2, 2025
rokroskar
temporarily deployed
to
renku-ci-ui-3712
GitHub Actions
Inactive
rokroskar
temporarily deployed
to
renku-ci-ui-3712
GitHub Actions
Inactive
|
Thanks @andre-code! I've made the change - I also updated all the links to point to the web version of the notion pages - otherwise it first tries to open the page in notion and I'm not sure what exactly that means for users who are not notion users. |
lorenzo-cavazzi
requested changes
Jun 4, 2025
rokroskar
temporarily deployed
to
renku-ci-ui-3712
GitHub Actions
Inactive
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "First time" message still points people to the legacy docs and tutorial. This redirects them to 2.0.
The banner now looks like this:
/deploy