Skip to content

refine: improve the selector fields for repo-based environments #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 27, 2025
Merged

refine: improve the selector fields for repo-based environments #3536

merged 12 commits into from
Feb 27, 2025

Conversation

leafty
Copy link
Member

@leafty leafty commented Feb 20, 2025 •
edited
Loading

PR stack:

New UI:

Screenshot 2025-02-25 at 09 21 15

Screenshot 2025-02-25 at 09 21 24

/deploy #notest renku=build/session-env-builders renku-data-services=kpack-resources renku-notebooks=leafty/shipwright-buildrun-cache extra-values=dataService.imageBuilders.enabled=true,dataService.imageBuilders.pushSecretName=flora-docker-secret,dataService.imageBuilders.buildRunRetentionAfterFailedSeconds=86400,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/flora-dev/

@leafty leafty temporarily deployed to renku-ci-ui-3536 February 20, 2025 12:14 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3536.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3536 February 20, 2025 13:01 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 20, 2025 13:16 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/session-env-builders-7 branch from 7308217 to 358317f Compare February 20, 2025 14:52
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 20, 2025 14:53 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 21, 2025 13:09 — with GitHub Actions Inactive
@leafty leafty mentioned this pull request Feb 24, 2025
Merged
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 24, 2025 11:55 — with GitHub Actions Inactive
This was referenced Feb 24, 2025
Merged
Merged
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 24, 2025 12:15 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 24, 2025 12:18 — with GitHub Actions Inactive
@leafty leafty mentioned this pull request Feb 24, 2025
Merged
@leafty leafty force-pushed the leafty/session-env-builders-6 branch from 8f89df2 to 2d79a72 Compare February 24, 2025 13:54
@leafty leafty force-pushed the leafty/session-env-builders-7 branch from 409135f to dab89e8 Compare February 24, 2025 14:14
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 24, 2025 14:18 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/session-env-builders-6 branch from 2d79a72 to 92fdbbb Compare February 24, 2025 16:02
@leafty leafty force-pushed the leafty/session-env-builders-7 branch from 737a305 to c9cd8e5 Compare February 24, 2025 16:06
@leafty leafty force-pushed the leafty/session-env-builders-7 branch from 88b23f8 to 61691f4 Compare February 25, 2025 08:09
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 25, 2025 08:09 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review February 25, 2025 08:23
@leafty leafty requested a review from a team as a code owner February 25, 2025 08:23
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 25, 2025 08:23 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi requested changes Feb 25, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Minor comments inline.

@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Feb 25, 2025
@leafty
Copy link
Member Author

leafty commented Feb 25, 2025

Note: the fields have a bug when the defaults are kept (not selecting e.g. Python). Will fix soon.

@leafty leafty force-pushed the leafty/session-env-builders-6 branch from 92fdbbb to 652cf35 Compare February 27, 2025 08:16
@leafty leafty force-pushed the leafty/session-env-builders-7 branch from 61691f4 to b7ba96e Compare February 27, 2025 08:25
@leafty leafty temporarily deployed to renku-ci-ui-3536 February 27, 2025 08:49 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

Base automatically changed from leafty/session-env-builders-6 to build/session-env-builders February 27, 2025 10:01
@leafty leafty merged commit 4a01d32 into build/session-env-builders Feb 27, 2025
17 checks passed
@leafty leafty deleted the leafty/session-env-builders-7 branch February 27, 2025 15:07
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@leafty leafty mentioned this pull request Feb 28, 2025
Merged
leafty added a commit that referenced this pull request Mar 6, 2025
@leafty
feat!: create a session image from a code repository (#3522)
8dac090 
Closes #3489.

This feature adds a new option when creating a session launcher: users can now choose to build a session image from one of their code repositories.

Contents:
* #3513
* #3491
* #3529
* #3536
* #3511
* #3543
leafty added a commit that referenced this pull request Apr 22, 2025
@leafty
feat!: create a session image from a code repository (#3522)
6e89dec 
Closes #3489.

This feature adds a new option when creating a session launcher: users can now choose to build a session image from one of their code repositories.

Contents:
* #3513
* #3491
* #3529
* #3536
* #3511
* #3543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafty @RenkuBot @lorenzo-cavazzi