Skip to content

Update navbars / add banner on v1 dashboard #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

Update navbars / add banner on v1 dashboard #3526

merged 3 commits into from
Apr 30, 2025

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Feb 6, 2025 •
edited
Loading

Legacy Navbar
image

Navbar
image

/deploy renku=ciyer/urls-v1-v2

@ciyer ciyer force-pushed the ciyer/v2-navbars branch 3 times, most recently from d4f105a to 4fbdca3 Compare February 7, 2025 12:01
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 7, 2025 12:20 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 7, 2025

You can access the deployment of this PR at https://renku-ci-ui-3526.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 17, 2025 09:22 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 17, 2025 10:54 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review February 17, 2025 13:20
@ciyer ciyer requested a review from a team as a code owner February 17, 2025 13:20
@ciyer ciyer temporarily deployed to renku-ci-ui-3526 February 20, 2025 15:52 — with GitHub Actions Inactive
leafty
leafty reviewed Feb 20, 2025
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal that the new legacy navbar only shows up for logged in users?

@leafty leafty self-assigned this Feb 20, 2025
@ciyer ciyer marked this pull request as draft March 5, 2025 09:05
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from e887f90 to 8478761 Compare March 18, 2025 09:21
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from 8846015 to 55d7490 Compare March 18, 2025 09:26
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from 8478761 to ccabf15 Compare March 24, 2025 08:20
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from 55d7490 to fe0e3f8 Compare March 24, 2025 08:41
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from ccabf15 to bee5e2d Compare March 24, 2025 10:15
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from fe0e3f8 to c1459d4 Compare March 24, 2025 10:18
@ciyer ciyer force-pushed the build/urls-v1-v2 branch from bee5e2d to 74ad8c8 Compare March 26, 2025 10:29
@ciyer ciyer force-pushed the ciyer/v2-navbars branch from c1459d4 to f42d003 Compare March 27, 2025 10:18
ciyer added a commit that referenced this pull request May 13, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526)
c696e6e
ciyer added a commit that referenced this pull request May 13, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526)
e69da55
ciyer added a commit that referenced this pull request May 13, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526)
61e2d9c
ciyer added a commit that referenced this pull request May 14, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526)
fe04505
ciyer added a commit that referenced this pull request May 14, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526)
6013ecf
ciyer added a commit that referenced this pull request May 14, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526)
30865be
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526)
2f17ce4
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526)
96dc365
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526)
20edc6c
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526) (#3521)
b9609f4
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526) (#3521)
9d47c38
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526) (#3521)
70012d7
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526) (#3521)
e6e23f6
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526) (#3521)
734be9d
ciyer added a commit that referenced this pull request May 16, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526) (#3521)
641fda4
ciyer added a commit that referenced this pull request May 20, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526) (#3521)
2c7efd5
ciyer added a commit that referenced this pull request May 20, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526) (#3521)
7d78cb7
ciyer added a commit that referenced this pull request May 20, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526) (#3521)
234ba29
ciyer added a commit that referenced this pull request May 22, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526) (#3521)
ca2ae97
ciyer added a commit that referenced this pull request May 22, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526) (#3521)
8128fa3
ciyer added a commit that referenced this pull request May 22, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526) (#3521)
159286d
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526) (#3521)
cee767a
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526) (#3521)
9033083
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526) (#3521)
7e9f1ec
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526) (#3521)
3a0a1ba
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526) (#3521)
23ca309
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526) (#3521)
56c2c94
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
minor: remove WIP badge from V1 secrets (#3526) (#3521)
5f7fbb6
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
refactor: update navbars for v2/legacy (#3526) (#3521)
842f2ae
ciyer added a commit that referenced this pull request May 23, 2025
@ciyer
feat: add v2 announcement banner on v1 dashboard (#3526) (#3521)
32d59e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

Assignees

@leafty leafty

Labels
ShapeUp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciyer @RenkuBot @leafty @lorenzo-cavazzi