-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add user page design #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3433.dev.renku.ch |
91824ab
to
34ab475
Compare
5c89a04
to
9ef2c8a
Compare
34ab475
to
64bc54b
Compare
64bc54b
to
5376abb
Compare
9ef2c8a
to
b891a8e
Compare
5376abb
to
0898a36
Compare
b891a8e
to
406e7d4
Compare
0898a36
to
1ad0ec1
Compare
const information = ( | ||
<div className={cx("d-flex", "flex-column", "gap-3")}> | ||
<div> | ||
<p className={cx("align-items-center", "d-flex", "gap-2", "mb-0")}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use me-2
on the Icon, all these classes are not needed except mb-0
.
Also, I don't think using a p
element is appropriate here since the semantic flow is broken. The whole Identifer: <username>
should be found inside a single p
if possible. Otherwise just use <div>
and <span>
.
</section> | ||
return ( | ||
<ContainerWrap className="position-relative"> | ||
<EntityWatermark type="user" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be broken just like for groups.
406e7d4
to
19c75b2
Compare
1ad0ec1
to
2c2210e
Compare
19c75b2
to
77e2d28
Compare
77e2d28
to
708bf74
Compare
…fix navigation from dashboard, improve avatar color generator
…ve green text when hover on avatar
…user information component
2c2210e
to
53f6cd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leafty The margin is part of the icon's SVG itself, and I couldn't find a suitable style to remove it. In this case, the solution would be to use a custom image instead, which I recommend to address in a separate PR. |
You could manually adjust the position for this case. |
Tearing down the temporary RenkuLab deplyoment for this PR. |
Apply new user page design
/deploy renku=release-0.62.0 renku-data-services=main