Skip to content

feat: add user page design #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Dec 9, 2024

Apply new user page design

/deploy renku=release-0.62.0 renku-data-services=main

@RenkuBot
Copy link
Contributor

RenkuBot commented Dec 9, 2024

You can access the deployment of this PR at https://renku-ci-ui-3433.dev.renku.ch

@andre-code andre-code force-pushed the andrea/user-page-redesign branch from 91824ab to 34ab475 Compare December 9, 2024 14:33
@andre-code andre-code force-pushed the andrea/user-page-redesign branch from 34ab475 to 64bc54b Compare December 10, 2024 09:58
@andre-code andre-code force-pushed the andrea/user-page-redesign branch from 64bc54b to 5376abb Compare December 10, 2024 12:00
@andre-code andre-code force-pushed the andrea/user-page-redesign branch from 5376abb to 0898a36 Compare December 10, 2024 14:39
@andre-code andre-code force-pushed the andrea/user-page-redesign branch from 0898a36 to 1ad0ec1 Compare December 11, 2024 08:55
@andre-code andre-code marked this pull request as ready for review December 12, 2024 08:10
@andre-code andre-code requested a review from a team as a code owner December 12, 2024 08:10
const information = (
<div className={cx("d-flex", "flex-column", "gap-3")}>
<div>
<p className={cx("align-items-center", "d-flex", "gap-2", "mb-0")}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use me-2 on the Icon, all these classes are not needed except mb-0.

Also, I don't think using a p element is appropriate here since the semantic flow is broken. The whole Identifer: <username> should be found inside a single p if possible. Otherwise just use <div> and <span>.

</section>
return (
<ContainerWrap className="position-relative">
<EntityWatermark type="user" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be broken just like for groups.

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design of the group and user pages do not look consistent, see the watermark here:

Screenshot 2024-12-17 at 11 48 28
Screenshot 2024-12-17 at 11 48 33

The alignment for the user watermark is not the same and there is no horizontal bar.

@andre-code
Copy link
Contributor Author

@leafty The margin is part of the icon's SVG itself, and I couldn't find a suitable style to remove it. In this case, the solution would be to use a custom image instead, which I recommend to address in a separate PR.

@leafty
Copy link
Member

leafty commented Dec 17, 2024

@leafty The margin is part of the icon's SVG itself, and I couldn't find a suitable style to remove it. In this case, the solution would be to use a custom image instead, which I recommend to address in a separate PR.

You could manually adjust the position for this case.

@andre-code andre-code merged commit d34a7c4 into andrea/group-page Dec 17, 2024
23 of 24 checks passed
@andre-code andre-code deleted the andrea/user-page-redesign branch December 17, 2024 13:38
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

andre-code added a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants