-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add new dashboard layout #3407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3407.dev.renku.ch |
8d80538
to
66c8efb
Compare
66c8efb
to
8ba55fe
Compare
…dashboard header image
006ce44
to
9c19dd5
Compare
Also, this is wrong, since the existing pages use the initials (which is much more appropriate) than the namespace slug. |
I understand the confusion. The changes required for the group and user pages are addressed in the other PRs. Here, you’ll see the avatar functioning consistently across all pages. https://renku-ci-ui-3433.dev.renku.ch/ |
Well, it is irksome to not see initials in that PR, to be honest. The initial component was created to use initials because it is what users would expect this type of "Avatar with initials" to be. Anyway, I will have a PR ready to fix the avatars and use initials (not just the first two letters). -> #3437 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be OK to merge now. Good work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, should be good to go once the footer cards are fixed.
className={cx( | ||
DashboardStyles.DashboardCard, | ||
"border-0", | ||
"position-relative" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this changes anything.
"position-relative" |
a svg { | ||
transition: all 0.3s linear; | ||
} | ||
a:hover svg { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small detail, but this would be nice:
a:hover svg { | |
a:hover svg, a:focus svg { |
Reference: https://webaim.org/techniques/hypertext/link_text#hover
Tearing down the temporary RenkuLab deplyoment for this PR. |
PR to add new dashboard layout
/deploy renku=andrea/update-dashboard-layout renku-data-services=main