Skip to content

feat: support launching sessions with data connectors #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 14, 2024
Merged

feat: support launching sessions with data connectors #3346

merged 5 commits into from
Oct 14, 2024

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Oct 10, 2024 •
edited
Loading

/deploy renku-data-services=leafty/build-data-connectors renku-notebooks=leafty/feat-data-connectors

@ciyer ciyer changed the base branch from main to ciyer/project-data-connector October 10, 2024 11:23
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3346.dev.renku.ch

@ciyer ciyer force-pushed the ciyer/data-connector-session branch from dbd6281 to 8ff2ebe Compare October 10, 2024 11:36
@ciyer ciyer temporarily deployed to renku-ci-ui-3346 October 10, 2024 11:56 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/data-connector-session branch from e066b35 to 3ab420a Compare October 10, 2024 12:58
@ciyer ciyer temporarily deployed to renku-ci-ui-3346 October 10, 2024 12:58 — with GitHub Actions Inactive
Base automatically changed from ciyer/project-data-connector to build/data-connectors October 11, 2024 09:22
@ciyer ciyer force-pushed the ciyer/data-connector-session branch from 3ab420a to 5ab3bca Compare October 11, 2024 12:02
@ciyer ciyer temporarily deployed to renku-ci-ui-3346 October 11, 2024 12:02 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/data-connector-session branch from 5ab3bca to 12e2c7d Compare October 11, 2024 12:50
@ciyer ciyer temporarily deployed to renku-ci-ui-3346 October 11, 2024 12:50 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/data-connector-session branch from 12e2c7d to 39dbbde Compare October 11, 2024 13:07
@ciyer ciyer temporarily deployed to renku-ci-ui-3346 October 11, 2024 13:07 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/data-connector-session branch from 39dbbde to 263dd9d Compare October 11, 2024 14:18
@ciyer ciyer marked this pull request as ready for review October 11, 2024 14:57
@ciyer ciyer requested a review from a team as a code owner October 11, 2024 14:57
leafty
leafty approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 . If merged now, we should check that all the tests pass on the feature branch.

@ciyer ciyer merged commit 958c9ce into build/data-connectors Oct 14, 2024
15 of 18 checks passed
@ciyer ciyer deleted the ciyer/data-connector-session branch October 14, 2024 08:45
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

ciyer added a commit that referenced this pull request Oct 14, 2024
@ciyer
feat!: introduce data connectors (#3315) (#3330) (#3334) (#3346)
e3d41c7 
* feat: support for data connectors on user and group namespaces (#3315)
* feat: set/edit secrets for data connectors (#3330)
* feat: data connectors on the project page (#3334)
* feat: support launching sessions with data connectors (#3346)

BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0
BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0

build: update to latest project api spec
ciyer added a commit that referenced this pull request Oct 16, 2024
@ciyer
feat!: introduce data connectors (#3315) (#3330) (#3334) (#3346) (#3359)
47d82b1 
* feat: support for data connectors on user and group namespaces (#3315)
* feat: set/edit secrets for data connectors (#3330)
* feat: data connectors on the project page (#3334)
* feat: support launching sessions with data connectors (#3346)
* minor: cosmetic improvements to data connectors (#3359)

BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0
BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0
ciyer added a commit that referenced this pull request Oct 17, 2024
@ciyer
feat!: introduce data connectors (#3315) (#3330) (#3334) (#3346) (#3359)
9bb0f67 
* feat: support for data connectors on user and group namespaces (#3315)
* feat: set/edit secrets for data connectors (#3330)
* feat: data connectors on the project page (#3334)
* feat: support launching sessions with data connectors (#3346)
* minor: cosmetic improvements to data connectors (#3359)

BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0
BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0
leafty pushed a commit that referenced this pull request Apr 22, 2025
@ciyer @leafty
feat!: introduce data connectors (#3315) (#3330) (#3334) (#3346) (#3359)
8553a12 
* feat: support for data connectors on user and group namespaces (#3315)
* feat: set/edit secrets for data connectors (#3330)
* feat: data connectors on the project page (#3334)
* feat: support launching sessions with data connectors (#3346)
* minor: cosmetic improvements to data connectors (#3359)

BREAKING CHANGE: Requires renku-data-services version >= 0.xx.0
BREAKING CHANGE: Requires renku-notebooks version >= 0.xx.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciyer @RenkuBot @leafty