fix: use direct links for logging in #3339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafty
temporarily deployed
to
renku-ci-ui-3339
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3339.dev.renku.ch |
leafty
had a problem deploying
to
renku-ci-ui-3339
GitHub Actions
Error
leafty
had a problem deploying
to
renku-ci-ui-3339
GitHub Actions
Error
leafty
had a problem deploying
to
renku-ci-ui-3339
GitHub Actions
Error
leafty
temporarily deployed
to
renku-ci-ui-3339
GitHub Actions
Inactive
leafty
had a problem deploying
to
renku-ci-ui-3339
GitHub Actions
Error
leafty
had a problem deploying
to
renku-ci-ui-3339
GitHub Actions
Error
leafty
had a problem deploying
to
renku-ci-ui-3339
GitHub Actions
Error
leafty
temporarily deployed
to
renku-ci-ui-3339
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3339
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3339
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3339
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3339
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3339
GitHub Actions
Inactive
andre-code
reviewed
Oct 8, 2024
leafty
had a problem deploying
to
renku-ci-ui-3339
GitHub Actions
Failure
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
leafty
added a commit
that referenced
this pull request
Apr 22, 2025
Fixes #3338, fixes SwissDataScienceCenter/renku-gateway#729. Remove the `/login` page (it was only doing a redirect) and replace all links to `/login` with links to `/api/auth/login` which is the login endpoint. Doing the redirect in-app added unnecessary complexity and caused HTTP 500 errors with the new gateway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3338, fixes SwissDataScienceCenter/renku-gateway#729.
Remove the
/loginpage (it was only doing a redirect) and replace all links to/loginwith links to/api/auth/loginwhich is the login endpoint.Doing the redirect in-app added unnecessary complexity and caused HTTP 500 errors with the new gateway.
/deploy renku=leafty/update-login-tests