Skip to content

Updated for compilation with multiple g++ and C++20 while resolving e… #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dt1729
Copy link

@dt1729 dt1729 commented May 15, 2023

Updated for compilation with multiple g++ and C++20 while resolving error in MARMaxPolicy.cpp for ranges_ vector

elementary edits for compilation on ubuntu 20.04 with multiple g++ installations and 9.4.0 set as default, this causes an error in MARMaxPolicy.cpp for ranges_ vector where iterating using (auto r : ranges_) is not feasible for some reason.

@Svalorzen
Copy link
Owner

Hey, sorry for the late reply.

I don't really see why this change makes sense for the project. If you have multiple g++ installed, there's no need to force g++-10 as the compiler (which might not even be installed if one has a newer version). Instead, you can generally pass such values as environmental variables to cmake.

As for the for loop change, the culprit is again a compiler that is too old, so I don't think it's worth changing (especially now that some time has passed).

@dt1729
Copy link
Author

dt1729 commented Mar 18, 2025

I believe at the time I was working on my primary ROS development machine. That particular compiler worked for most of my projects so I had to make it work for this library. Forced change for this library and definitely not a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants