Skip to content

New doc- CrowdStrike Falcon FileVantage (Apps) #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 9, 2024
Merged

New doc- CrowdStrike Falcon FileVantage (Apps) #4849

merged 13 commits into from
Dec 9, 2024

Conversation

amee-sumo
Copy link
Collaborator

@amee-sumo amee-sumo commented Dec 6, 2024 •
edited
Loading

Purpose of this pull request

This pull request is to create a new apps doc - CrowdStrike Falcon FileVantage

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-586

@amee-sumo amee-sumo added doc:new New section or topic to content do-not-merge Pull requests that should not be merged labels Dec 6, 2024
@amee-sumo amee-sumo self-assigned this Dec 6, 2024
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Dec 6, 2024
jpipkin1
jpipkin1 reviewed Dec 6, 2024
View reviewed changes
jpipkin1
jpipkin1 reviewed Dec 6, 2024
View reviewed changes
jpipkin1
jpipkin1 reviewed Dec 6, 2024
View reviewed changes
jpipkin1
jpipkin1 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @amee-sumo! I have only minor suggestions.

amee-sumo and others added 5 commits December 9, 2024 09:17
@amee-sumo @jpipkin1
Update docs/integrations/saas-cloud/crowdstrike-falcon-filevantage.md
5676d73 
Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@amee-sumo @jpipkin1
Update docs/integrations/saas-cloud/crowdstrike-falcon-filevantage.md
9091f19 
Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@amee-sumo @jpipkin1
Update docs/integrations/saas-cloud/crowdstrike-falcon-filevantage.md
624c837 
Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812
Update crowdstrike-falcon-filevantage.md
dd791e1
@JV0812
Update 2024-12-11-apps.md
087b3f1
JV0812
JV0812 requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the images uploaded to the S3 bucket. The dashboard images do not have the required clarity while viewing the file. Can you please export the dashboard image from the platform and upload it to S3?
Screenshot 2024-12-09 at 2 20 36 PM

@amee-sumo amee-sumo requested a review from JV0812 December 9, 2024 10:20
JV0812
JV0812 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpipkin1
Copy link
Collaborator

jpipkin1 commented Dec 9, 2024

Publishing this PR at the request of @ankitgoelcmu.

@jpipkin1 jpipkin1 enabled auto-merge December 9, 2024 20:08
@jpipkin1 jpipkin1 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit fc79481 Dec 9, 2024
7 checks passed
@jpipkin1 jpipkin1 deleted the CrowdStrike-Falcon-FileVantage-App branch December 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@JV0812 JV0812 JV0812 approved these changes

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

Assignees

@amee-sumo amee-sumo

Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged doc:new New section or topic to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amee-sumo @jpipkin1 @JV0812