Updated doc for AWS tag filters and AWSO apps #4827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhil-sumologic
requested review from
kimsauce,
jpipkin1,
JV0812,
mafsumo and
amee-sumo
as code owners
jpipkin1
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Approved, @akhil-sumologic. I made minor changes (see commit "Updates from review").
I can see why you added spaces to the table to make it display wider. But generally, we let the table width be set automatically. (See Tables in our style guide.)
|
@akhil-sumologic, can we merge this PR now? |
amee-sumo
approved these changes
Dec 9, 2024
I fixed the table. |
This will be released in January as part of the AWSO 2.11.0 update. |
akhil-sumologic
changed the title
amee-sumo
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request...
Select the type of change
Ticket (if applicable)
https://sumologic.atlassian.net/browse/SUMO-251934