Skip to content

macro Operator docs #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 15, 2025
Merged

macro Operator docs #4767

merged 19 commits into from
Jan 15, 2025

Conversation

JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Nov 18, 2024

Purpose of this pull request

This pull request is to create documentation for our new macro Operator.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

Create documentation for Macro Operator

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Nov 18, 2024
@JV0812 JV0812 self-assigned this Nov 18, 2024
@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Nov 18, 2024
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, JV!! Look forward to learning more about this new operator. Just had a few suggestions.

Copy link

@charlessumo charlessumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, I think @manashar4 should take a look here too

JV0812 and others added 7 commits November 25, 2024 14:07
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@JV0812 JV0812 requested a review from charlessumo November 28, 2024 07:23
@JV0812 JV0812 requested a review from amee-sumo as a code owner November 28, 2024 13:31
@jpipkin1
Copy link
Collaborator

jpipkin1 commented Jan 9, 2025

@JV0812, shouldn't there be a release note for this feature? It's a big one.

Also, this functionality seems buried by placing it under the Search Operators reference. Shouldn't you place most of the instructions about how to create macros in a new more visible article under "Search Basics"?

JV0812 and others added 2 commits January 10, 2025 16:54
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@JV0812 JV0812 requested a review from manashar4 January 13, 2025 13:23
@JV0812
Copy link
Collaborator Author

JV0812 commented Jan 13, 2025

@jpipkin1 Thanks for your suggestions.

  • Mostly, this docs will be a Beta release, if confirmed for Beta release I will remove the doc from the sidebar or I will create the release note for the same.
  • Let me have a discussion with the Engineering team and confirm on the placeholder. I guess we can keep all these information in the same doc for a Beta release, later we can split it up as you suggested for a common release.

@JV0812 JV0812 enabled auto-merge January 15, 2025 08:52
@JV0812 JV0812 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit b1f5fe9 Jan 15, 2025
7 checks passed
@JV0812 JV0812 deleted the macro-operator-docs branch January 15, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants