Skip to content

Add metrics collection and metrics-based dashboards info to Memcached OTel app doc #4219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 4, 2024
Merged

Add metrics collection and metrics-based dashboards info to Memcached OTel app doc #4219

merged 11 commits into from
Jul 4, 2024

Conversation

sumoanema
Copy link
Collaborator

@sumoanema sumoanema commented Jun 19, 2024 •
edited by kimsauce
Loading

Purpose of this pull request

Changes to memcache-otel app doc after changes in it to add metric collection and metric-based dashboards

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jun 19, 2024
@sumoanema sumoanema requested a review from kimsauce June 24, 2024 05:57
@kimsauce kimsauce changed the title Changes in memcache-otel app doc after changes in it to add metric co… Add metrics collection and metrics-based dashboards info to Memcached OTel app doc Jun 24, 2024
@sumoanema @kimsauce
Apply suggestions from code review
7acc963 
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@sumoanema sumoanema requested a review from kimsauce June 26, 2024 06:51
@sumoanema sumoanema marked this pull request as ready for review June 28, 2024 06:53
JV0812
JV0812 reviewed Jun 28, 2024
View reviewed changes
JV0812
JV0812 reviewed Jun 28, 2024
View reviewed changes
JV0812
JV0812 reviewed Jun 28, 2024
View reviewed changes
JV0812
JV0812 requested changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes

@sumoanema @JV0812
Apply suggestions from code review
f9c6a89 
Co-authored-by: Jagadisha V <129049263+JV0812@users.noreply.github.com>
@sumoanema sumoanema requested a review from JV0812 June 28, 2024 09:23
JV0812
JV0812 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumoanema sumoanema added the do-not-merge Pull requests that should not be merged label Jun 28, 2024
@sumoanema sumoanema removed the do-not-merge Pull requests that should not be merged label Jul 4, 2024
@sumoanema sumoanema added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit f67083f Jul 4, 2024
3 checks passed
@sumoanema sumoanema deleted the memcachedOtel branch July 4, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@JV0812 JV0812 JV0812 approved these changes

@kimsauce kimsauce Awaiting requested review from kimsauce kimsauce is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

Assignees

@sumoanema sumoanema

Labels
cla-signed Contributor approved, listed in .clabot file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumoanema @kimsauce @jpipkin1 @JV0812