Skip to content

DOCS-107 - CIS for AWS CloudQuery - onboarding improvements #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Oct 21, 2024
Merged

DOCS-107 - CIS for AWS CloudQuery - onboarding improvements #4209

merged 53 commits into from
Oct 21, 2024

Conversation

jpipkin1
Copy link
Collaborator

@jpipkin1 jpipkin1 commented Jun 13, 2024 •
edited
Loading

Purpose of this pull request

This pull request removes CloudQuery from the following article and refreshes the installation procedure:
https://help.sumologic.com/docs/security/cloud-infrastructure-security/cloud-infrastructure-security-for-aws/

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

DOCS-107

@jpipkin1 jpipkin1 added doc:update Revisions and updates to content do-not-merge Pull requests that should not be merged labels Jun 13, 2024
@jpipkin1 jpipkin1 self-assigned this Jun 13, 2024
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jun 13, 2024
@jpipkin1
Copy link
Collaborator Author

@ajaiswals, could you review this PR?

@jpipkin1
Copy link
Collaborator Author

@JV0812 or @kimsauce, could one of you review this PR? There's no rush, since it doesn't release until Aug. 1.

kimsauce
kimsauce reviewed Jul 1, 2024
View reviewed changes
kimsauce
kimsauce approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Had one clarifying question and then the rest are suggestions.

@jpipkin1 @kimsauce
Update blog-service/2024-08-01-apps.md
d2600c8 
Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@jpipkin1
Copy link
Collaborator Author

jpipkin1 commented Jul 1, 2024

Thanks for the review, @kimsauce.

jpipkin1 and others added 2 commits July 1, 2024 10:09
@jpipkin1 @kimsauce
Update docs/security/cloud-infrastructure-security/cloud-infrastructu…
0aed81a 
…re-security-for-aws.md

Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@jpipkin1
Merge branch 'main' into docs-107-cloudquery-ga
5d4c956
@jpipkin1 jpipkin1 changed the title DOCS-107 - CIS for AWS CloudQuery GA DOCS-107 - CIS for AWS CloudQuery - cleanup Aug 13, 2024
This was referenced Aug 14, 2024
Merged
Merged
Merged
@kimsauce
Copy link
Collaborator

Thanks for the heads up! Do you need help with anything? Would you also have to remove static/files/c2c/cloudquery-gcp/example.json and static/files/c2c/cloudquery-gcp/example.tf?

@jpipkin1
Copy link
Collaborator Author

Thanks for catching that, @kimsauce! I removed all the CloudQuery static files with commit "Remove downloadable files for CloudQuery sources".

@jpipkin1 jpipkin1 changed the title DOCS-107 - CIS for AWS CloudQuery - cleanup DOCS-107 - CIS for AWS CloudQuery - onboarding improvements Sep 25, 2024
@jpipkin1 jpipkin1 enabled auto-merge October 21, 2024 16:40
@jpipkin1 jpipkin1 added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit fab9d69 Oct 21, 2024
7 checks passed
@jpipkin1 jpipkin1 deleted the docs-107-cloudquery-ga branch October 21, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimsauce kimsauce kimsauce approved these changes

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@ajaiswals ajaiswals Awaiting requested review from ajaiswals

@ankitgoelcmu ankitgoelcmu Awaiting requested review from ankitgoelcmu

Assignees

@jpipkin1 jpipkin1

Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged doc:update Revisions and updates to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpipkin1 @kimsauce