Better logging of token permission issues #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| label_data = { | ||
| "name": label, | ||
| "description": "Feedback from a Docassemble Interview", | ||
| "color": "002E60", | ||
| } | ||
| make_label_resp = requests.post( | ||
| labels_url, data=json.dumps(label_data), headers=headers | ||
| labels_url.rsplit("/", 1)[0], # POST to /labels (collection) |
There was a problem hiding this comment.
Not a huge fan of splitting the URL like this. I'm fine with just having two variables (one for labels_url and one for single_label_url above if you don't want to add to the url like it was.
BryceStevenWilley
requested changes
Jul 8, 2025
Yes, in the event it is flagged as spam, there was a Python error (a,b = None should have been a = b = None) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user feedback is attempted, have a better log message for feedback.
Also cleaned up label authoring and fixed a bug when feedback was caught as likely spam.