Skip to content

Improve number references #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Improve number references #493

merged 1 commit into from
Jan 10, 2025

Conversation

samglover
Copy link
Contributor

This PR is an attempt to clarify the references in the text to the numbers in the images on the answer sets page.

Closes #247

@samglover samglover requested a review from plocket December 16, 2024 19:55
@plocket
Copy link
Collaborator

plocket commented Dec 19, 2024

Starting a review 👍

Copy link
Collaborator

@plocket plocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this clarification and these look correct to me. I feel mixed about bold vs. quotes around the numbers. I see pros and cons either way ¯\_(ツ)_/¯

I did leave one comment unrelated to this PR because my memory banks are purely external. Sorry about that.

@@ -75,12 +72,11 @@ set.
To rename an answer set, first visit the answer set's information page:

1. Find the answer set in the "My interviews" page and click to open
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangential nit: I realize you didn't write this, but doesn't clicking on the interview on the "My interviews" page open the interview? Am I wrong - does that instead open an intermediate page where you edit the answer set (for the interviews that have answer sets)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is accurate as per the full context--when you choose "load answer set" inside a running interview, you get a list of answer sets. clicking one loads that set of answers into the running interview.

@samglover samglover merged commit 78bf161 into main Jan 10, 2025
2 checks passed
@samglover samglover deleted the 247_improve_number_references branch January 10, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Answer set: Improve use of numbers in pictures
3 participants