Parameterizing Future
types
#93
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea here is that we'd like to use a parameterized
Future
type instead of more specific instances with associated methods and instead implement additional helpers as functions that are also parameterized by theFuture
types they accept and return.This change would incur some amount of breaking changes, but maintain equivalent functionality with the goal of simplifying code/understandability for future SDK user code.
Future types will be represented as a single
Future
generic typeString Futures no longer implement the
.concat
instance methodThis method was already exported under
sb
and can continue to be used as expected.Object Futures no longer implement the
.get
instance methodThis method will be exported under
sb
(similar to other future methods)sb.jq
helper function accepts non-string type parameters and deprecates type-mapping argumentCode that uses these previous type mappings should be updated.