Skip to content

Scope in as keyword.control again #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025
Merged

Scope in as keyword.control again #86

merged 1 commit into from
May 4, 2025

Conversation

FichteFoll
Copy link
Member

See also sublimehq/Packages#4227 for a prior discussion of this.

@FichteFoll FichteFoll added this to the 2.0.0 milestone May 4, 2025
@deathaxe
Copy link
Member

deathaxe commented May 4, 2025

As current iteration operator scope is actually only used in for or foreach statements, scoping in keyword.control.loop.in appears quite reasonable. I appriciate it not being under a .for subscope, but being scoped a bit more neutral.

We should then use it everywhere in default packages and those in this organization.

@FichteFoll
Copy link
Member Author

We should then use it everywhere in default packages and those in this organization.

Indeed, I wanted to propose it like this but haven't gotten to it yet. The only remaining question that I asked myself ahead of time and haven't found an answer to yet was what to do with JavaScript's of.

@FichteFoll FichteFoll merged commit 6a5135f into master May 4, 2025
2 checks passed
@FichteFoll FichteFoll deleted the bugfix/in-scope branch May 4, 2025 21:41
FichteFoll added a commit to SublimeText/PackageDev that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants