Skip to content

Feature/chatbot secrets compatibility #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

joshlavroff
Copy link
Contributor


name: Pull Request
about: Create a pull request to contribute to the project
title: ''
labels: ''
assignees: ''

Description of Changes
API keys for the chat component can now be loaded from a project's secrets.toml file. Keys that are entered during a session are not saved and will remain only in the sessionStorage until the app is closed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • New example
  • Test improvement

Testing
Code has been tested against the currently present chat example in the Iris example project.

Screenshot (812)
Screenshot (813)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run my code against examples and ensured no errors
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@shivam-singhal shivam-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshlavroff looks great. Can you cherry pick the relevant commits and move them to a new branch? This PR includes already merged/closed commits from weeks ago. After that, will be good to merge!

@shivam-singhal
Copy link
Member

@joshlavroff also, can you attach a screen recording as well?

@joshlavroff
Copy link
Contributor Author

@shivam-singhal Yes I've just opened a new PR with these fixes #630

@amrutha97 amrutha97 force-pushed the main branch 2 times, most recently from 6ac1dad to bdb2c4e Compare April 24, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants