Skip to content

Update PlayFabHttp.gd #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update PlayFabHttp.gd #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
497ab1d
Update PlayFabHttp.gd
martin951 Oct 4, 2025
ff5d243
Merge branch 'develop' into patch-1
Structed Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions addons/godot-playfab/PlayFabHttp.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,24 @@ func _http_request(request_method: int, body: Dictionary, path: String, callback
if parse_error != OK:
emit_signal("json_parse_error", json_parse_result)
return
if response_code >= 200 and response_code < 400:
if callback != null:
if callback.is_valid():
callback.call(json_parse_result)
else:
push_error("Response calback " + callback.get_method() + " is no longer valid! Make sure, a script is only removed after all requests returned!")

if callback == null:
push_error("Response calback is null!")
return

if not callback.is_valid():
push_error("Response calback " + callback.get_method() + " is no longer valid! Make sure, a script is only removed after all requests returned!")
return
elif response_code >= 400:


# Intended use includes await - always invoke the callback.
# Note: response_code 400 may not mean network or server error!
# (e.g. "UpdateUserTitleDisplayName" may return { "code": 400.0, "status": "BadRequest", "error": "NameNotAvailable", "errorCode": 1058.0, "errorMessage": "Name not available" }.)
callback.call(json_parse_result)


# Emit error signals as metadata on top of the response - can be "subscribed" to on demand.
if response_code >= 400:
var apiErrorWrapper = ApiErrorWrapper.new()
for key in json_parse_result.keys():
apiErrorWrapper.set(key, json_parse_result[key])
Expand Down